-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu not loading in Edge #4784
Comments
Possible duplicate? #4772 |
I remember trying it on the latest Edge and couldn't reproduce. |
Hi Sharkykh thanks for the reply, I tried that and nothing the issue remains. I have also cleared cookies and cache and tried on multiple PC's and the issue remains. Works fine in Firefox though but not private browsing. |
You should try the |
This comment has been minimized.
This comment has been minimized.
@sharkykh and @OmgImAlexis I had some spare time today and tried to troubleshoot this further. I think I have a cause but not a solution. I use a reverse proxy on NGINX to access the site if I navigate to the site using the internal IP, Port and base URL lets says http://127.0.0.1:8081/TV it works fine. I changed the base URL in Medusa and the reverse proxy and it still never worked which makes me think it is something in the reverse proxy setup I have causing the issue. I compared my proxy settings to the ones on https://github.com/pymedusa/Medusa/wiki/Reverse-Proxy-setup and the only difference was the top 2 lines mine has:
Which I expected, I am sure this is something simple but I cannot see what it is! if either of you have any ideas I would really appreciate it! |
|
Hi Sharkykh no worries hopefully someone else can help with the reverse proxy bit. When I navigate directly using the internal IP the syntax errors disappear I will update as soon as it is available and let you know if it fixes it. |
Well I can confirm, but for me it's already not loading the login page.
Seems to have something to do with the WebSocket. return r(e, [{ key: "connect", value: function value(e) {
var t = this,
n = arguments.length > 1 && void 0 !== arguments[1] ? arguments[1] : {},
o = n.protocol || "";return this.WebSocket = n.WebSocket || ("" === o ? new WebSocket(e) : new WebSocket(e, o)), "json" === this.format && ("sendObj" in this.WebSocket || (this.WebSocket.sendObj = function (e) {
return t.WebSocket.send(JSON.stringify(e));
})), this.WebSocket; But unfortunately I can't trace it back to a source file. |
Where did you get that websocket code? Also, please check the first error:
|
@sharkykh is that trying to connect the websocket on the login page? If so it won't be authenticated, that may be the issue? |
I cant see the syntax error. Anything i can check? |
@OmgImAlexis It's possible that's the case on |
Im running develop. The syntax highlighted piece of code is from that error. |
I'm changing this to bug prio high. As medusa is just not working at all with it. So either we should fix this asap. @pymedusa/developers thoughts? |
IMO it should be fixed rather than dropping support for Edge. @p0psicles And actually, looks like I was mistaken. The websocket is initialized on the I have a hunch Edge doesn't support the full spec of the native WebSocket client: |
I know that edge has troubles with unhandled promises or exceptions. |
@p0psicles It's possible, maybe the URL it tries to connect is incorrect, you should look for that when you're debugging. If you want to debug using that source, you can try changing this import:
to: import VueNativeSock from 'vue-native-websocket/src/Main'; |
That didn't make any difference. Or at least it's still minified. Drilled it down to this: this is causing the error: Similar issue: I think it's causing the error because of a colon. |
Yeah that fixed it. I'll clean up the branch and PR it. |
@p0psicles |
Thanks @p0psicles for looking at it, I appreciate it. Thanks everyone else for the help on this one. |
Fixed in develop with #4928. |
Describe the bug
In todays update if I go to the webpage then the menu that should appear in the upper right hand corner is missing as can be seen in the below image.
If I use Firefox then the menu appears.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Menu appears
Edge Log
I used F12 and under Console I have 8 errors shown:
The text was updated successfully, but these errors were encountered: