Check cache for candidates when searching using backlog search. #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DeepCode analyzed this pull request. |
|
@medariox let's refine this PR some more and then merge to develop. The user can only test master/develop as he is running on synology. |
Fixed same flake comments.
so they're not erased with a second loop on season back episode fallback.
As I don't like the existing find_needed_episodes. As I think that method does too much.
…eck-cache-for-candidates
|
Im pretty much done with this. Tried to make it a little bit more DRY. And ran different searches. |
medariox
approved these changes
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5582
This should be extensively tested before merging.
ASIS: In each backlog for every episode search, we check the cache if we get anything back. If so, we dont bother searching the provider. This makes the searching process heavily dependent on the Daily/RSS search.
With this change, we also check if the results from cache, include any candidates, where we also check quality, required words, release groups, etc.
If the results do not have any candidates, we start a search for the provider.