-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in tests from #95 - numpy 1.11.0 is no longer matched to manylinux #107
Comments
Just to test my theory that #95 was the source of the regression, I reverted the merge commit and ran the tests against that. They pass again, so something in the logic of that PR broke things. I'm going to use that knowledge to try to hunt down and fix the bug, but if I can't find it are you okay with me reverting the PR @lpsinger? Mainline auditwheel seems to be broken, I'm not sure why no one noticed since I released the changes in 1.9... |
Okay, I think I've tracked this down. For context, the test failure looks like:
Since the result of #95 is that auditwheel looks at all ELF files in the wheel, it seems that we end up misprocessing the repaired ELF files that we grafted during the repair step into
And as you can see, the |
The external libraries showing up in this map with "null" keypairs is causing legitimate wheels to be misidentified as non-manylinux. We missed this because the tests appeared to be passing, due to #105.
The text was updated successfully, but these errors were encountered: