Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix for PEP 685 in packaging 22 #550

Merged
merged 1 commit into from
Dec 13, 2022
Merged

tests: fix for PEP 685 in packaging 22 #550

merged 1 commit into from
Dec 13, 2022

Conversation

henryiii
Copy link
Contributor

Support Packaging 22.

@henryiii henryiii marked this pull request as draft December 10, 2022 04:21
@layday
Copy link
Member

layday commented Dec 10, 2022

If packaging doesn't normalise dependency names when stringifying dependencies, why does it normalise their extras? Anyway, the easiest thing to do here is to replace all underscores in extra names in the tests with hyphens.

@layday layday mentioned this pull request Dec 12, 2022
Closed
@nanonyme
Copy link

@layday maybe it should? Sounds like worth filing issue on packaging.

@henryiii henryiii mentioned this pull request Dec 13, 2022
Open
@henryiii henryiii force-pushed the henryiii/tests/fix22 branch from 4cc1f95 to a64b751 Compare December 13, 2022 16:06
@henryiii
tests: fix for PEP 685 in packaging 22
6fd0b36 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/tests/fix22 branch from a64b751 to 6fd0b36 Compare December 13, 2022 16:21
@layday
Copy link
Member

layday commented Dec 13, 2022

This only affects extra names in markers, BTW, not square bracket extra selectors.

@nanonyme
Copy link

That sounds inconsistent enough to definitely warrant an upstream issue.

@henryiii
Copy link
Contributor Author

But those have to be consistent to make older packaging pass, since older packaging does not consider a-b to match a_b.

@henryiii henryiii marked this pull request as ready for review December 13, 2022 17:03
@henryiii
Copy link
Contributor Author

RtD is misbehaving today, also in pypa/packaging.

@nanonyme
Copy link

@henryiii is RtD supposed to work from forks at all?

@henryiii
Copy link
Contributor Author

henryiii commented Dec 13, 2022 •
edited
Loading

RtD supposed to work from forks at all?

I think so. Never had a problem before. I think GH is finicky today.

@henryiii henryiii closed this Dec 13, 2022
@henryiii henryiii reopened this Dec 13, 2022
@henryiii
Copy link
Contributor Author

Passes now, so yes. :)

@henryiii henryiii merged commit 76d90b9 into pypa:main Dec 13, 2022
@henryiii henryiii deleted the henryiii/tests/fix22 branch December 13, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layday layday layday approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @layday @nanonyme