Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to do once Python 3.5 host support is dropped #316

Closed
YannickJadoul opened this issue Apr 8, 2020 · 5 comments
Closed

Things to do once Python 3.5 host support is dropped #316

YannickJadoul opened this issue Apr 8, 2020 · 5 comments

Comments

@YannickJadoul
Copy link
Member

List of things we could potentially do once we require a minimal Python version of 3.6 to execute cibuildwheel.

  • f-strings!
  • pathlib (pathlib already exists in 3.5, but the path protocol doesn't, so lots of conversions to str are required).

If we have typing:

  • Variable annotation syntax (local variables and NamedTuple)
@Czaki
Copy link
Contributor

Czaki commented Apr 8, 2020

Remove object inheritance eg in DependencyConstraints (it should be done earlier)

What do you think about work with async (or threading) for speedup work (start installing next python before previous build wheel is finished)?

@YannickJadoul
Copy link
Member Author

YannickJadoul commented Apr 8, 2020

Remove object inheritance eg in DependencyConstraints (it should be done earlier)

That's Python 2 vs. 3? I coul quickly commit that to master without PR, actually, if you want?

What do you think about work with async (or threading) for speedup work (start installing next python before previous build wheel is finished)?

Not sure. I still feel that keeping things as slmple as possible is what we should aim for with cibuildwheel. I personally would rather have this tool work twice as slow but consistently, than have random failures because the installation accidentally added something the wheel building step did not expect?

@Czaki
Copy link
Contributor

Czaki commented Apr 8, 2020

There are special options to be sure that some tasks not start before the one its depend on it finish.
But I'm not sure if speed-up if worth of higher complexity.

That's Python 2 vs. 3? I coul quickly commit that to master without PR, actually, if you want?

This is simple code cleaning from unnecessary parts. It should be done in some moment.

@YannickJadoul
Copy link
Member Author

Remove object inheritance eg in DependencyConstraints (it should be done earlier)

@Czaki: not exactly the largest commit ever, but... b8dbedc

@joerick
Copy link
Contributor

joerick commented Jul 11, 2020

This is all done :)

@joerick joerick closed this as completed Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants