Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for manylinux2010 #65

Closed
mayeut opened this issue May 2, 2018 · 10 comments
Closed

Add support for manylinux2010 #65

mayeut opened this issue May 2, 2018 · 10 comments

Comments

@mayeut
Copy link
Member

mayeut commented May 2, 2018

Add support for manylinux2010

c.f. pypa/manylinux#179

@YannickJadoul
Copy link
Member

Thanks for notifying!
I'd expect this to be a rather easy change to cibuildwheel, once manylinux2010 becomes ready to use, be we should keep an eye on those developments :-)

@dolang
Copy link

dolang commented May 3, 2018

Just stumbled across this because I found the tracking issue on the manylinux repository. :)

This looks rather interesting.

I've started trying to build manylinux2010 wheels a while ago, and have a pull request up (pypa/manylinux#182). It's not official, but I've based it on the original manylinux2 pull request and it actually produces wheels already.

Just in case you want something to play with. Or I might do it the other way around when I have some time. 👍

P.S. just FYI: support for py3.3 is dropped with the update to wheel v0.31.0, so I'm assuming it won't be part of manylinux2010 either, once that's official.

@joerick
Copy link
Contributor

joerick commented Jun 18, 2018

So I'm guessing we'll add this as a separate python configuration, alongside manylinux1?

@YannickJadoul
Copy link
Member

Seems manylinux2010 is almost ready, so we could start experimenting with how to add it to cibuildwheel. I'm quite happy/eager to play around with it a bit, if I find time, so I'll see if I can make a PR, soon :-)

@joerick What exactly did you mean/have in mind, here?

So I'm guessing we'll add this as a separate python configuration, alongside manylinux1?

Something that can be matched by CIBW_BUILD and CIBW_SKIP?

@joerick
Copy link
Contributor

joerick commented Apr 20, 2019

Something that can be matched by CIBW_BUILD and CIBW_SKIP?

This was my initial guess, yes

@hameerabbasi
Copy link

I ran into needing this for my project, see: Quansight-Labs/uarray#193

@mayeut
Copy link
Member Author

mayeut commented Sep 22, 2019

Cross-Reference #155

@jlaine
Copy link
Contributor

jlaine commented Oct 18, 2019

It looks like manylinux2010 is now officially supported and there are wheel on PyPI. What's needed to add support to cibuildwheel?

@YannickJadoul
Copy link
Member

@jlaine, #155 adds manylinux2010 support and is ready to be merged.
But given that this will be a new release, deprecating some old options, I had the impression @joerick wanted to still merge some other PRs before releasing?

@joerick
Copy link
Contributor

joerick commented Nov 4, 2019

Fixed in #155, release should be soon!

@joerick joerick closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants