Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the versions of PyPy #743

Closed
mattip opened this issue Jul 1, 2021 · 5 comments
Closed

Update the versions of PyPy #743

mattip opened this issue Jul 1, 2021 · 5 comments

Comments

@mattip
Copy link
Contributor

mattip commented Jul 1, 2021

xref numpy/numpy#19383 where an older version of cibuildwheel (1.7.4) tripped up a user since they were getting a much older PyPy.

@mattip
Copy link
Contributor Author

mattip commented Jul 1, 2021

I think PyPy on windows 64 is also supported now, no?

@henryiii
Copy link
Contributor

henryiii commented Jul 1, 2021

You need cibuildwheel 2.0 get get windows 64, which is not fully out yet (a bug in pip is in the way for build support, #740, and a few other things). But the everything that was supported before should still be stable, so using 2.0.0a4 should be safe unless you are activating the experimental pypa/build support.

cibuildwheel pins everything by default. So they need to update the cibuildwheel pin.

The readme should be correct - the docs are for cibuildlwheel 1.x until the new release, unless you go to the latest version. Default is stable.

@mattip
Copy link
Contributor Author

mattip commented Jul 1, 2021

Supporting PyPy 7.3.3 as the last version is problematic, as pointed out in the issue above. That version of PyPy does not play well with some versions of NumPy. Does changing a PyPy version require a new version of cibuildwheel?

@mattip mattip changed the title Update the versions of PyPy supported in the README and other documentation Update the versions of PyPy Jul 1, 2021
@henryiii
Copy link
Contributor

henryiii commented Jul 1, 2021

We could backport the update to the 1.x branch, I suppose. One of the biggest issues is that pypy3.6 was dropped in the latest version, so this would be a bit of a bigger change than we wanted to deal with - would need to be 1.12 (also of course the change to Windows 64). Also, we currently are using the manylinux* wheels, which are 3.7+ only (no 2). Also, since we'd already dropped Python 2, the backport might not initially handle pypy2 correctly.

I might be willing to give it a shot later if it seems like a good idea.

@mattip
Copy link
Contributor Author

mattip commented Jul 2, 2021

Ahh, I see. So more trouble than it is worth it seems. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants