Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE* files not included in the SDist (via standard tooling) #549

Closed
henryiii opened this issue May 12, 2022 · 2 comments
Closed

LICENSE* files not included in the SDist (via standard tooling) #549

henryiii opened this issue May 12, 2022 · 2 comments

Comments

@henryiii
Copy link
Contributor

When building an SDist via pipx run build, flit doesn't include LICENSE* files, so when building the wheel also via pipx run build, there are no licenses files unless there is a license = {files = ...} key (and then only one file is allowed). However, when directly building the wheel, using pipx run build --wheel without going through an SDist first, then LICENSE* is included, see

for path in sorted(self.directory.glob(base + '*')):
.

#540 is slightly related. Noticed when trying to setup packaging on Flit in pypa/packaging#340 (comment) .

@bhrutledge
Copy link

Duplicate of #379?

@takluyver
Copy link
Member

Yes, I think #379 covers this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants