Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatch release: --strict flag is misleading? #91

Closed
karlicoss opened this issue Dec 20, 2019 · 1 comment
Closed

hatch release: --strict flag is misleading? #91

karlicoss opened this issue Dec 20, 2019 · 1 comment

Comments

@karlicoss
Copy link

At the moment --help for hatch release says: -s, --strict Aborts if a distribution already exists..

I expected it to exit with non-zero code if the package already existed.
However, behaviour seems to be the opposite of what I expect:

$ hatch release 
Uploading distributions to https://upload.pypi.org/legacy/
  Skipping cachew-0.6-py2.py3-none-any.whl because it appears to already exist
(exit code 0)
$ hatch release --strict 
Uploading cachew-0.6-py2.py3-none-any.whl
100%
(exit code 0)

So instead of aborting, --strict have forced uploading.
It seems that the option simply forwards to --skip-existing of twine upload, which means:

--skip-existing       Continue uploading files if one already exists. 

Should the --strict flag do exactly the opposite? Also --abort normally implies non-zero exit code, I think; is hatch meant to implement this logic?

Happy to open a PR fix it, just not sure what was the original intent. Thanks.

@ofek
Copy link
Collaborator

ofek commented Dec 30, 2021

Hatch has been rewritten from scratch and now no longer uses twine so no more --strict, see https://ofek.dev/hatch/latest/publish/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants