Add a LegacySpecifierSet #92
Conversation
|
Huh, I'm not sure what the tests that are failing mean. I'll take a look to figure out why. |
|
Yeah, it looked like it couldn't find Python 2.6? I ran |
|
@jimporter Could you rebase on master ? |
jimporter
force-pushed
the
legacy-specifier-set
branch
from
8c74c88 to
50c0aa3
Compare
|
@xavfernandez Ok, rebased. Sorry for not seeing this sooner! |
|
Travis is failing because not all of this new behavior is covered by tests. The exact lines that aren't covered are indicated in the job output. Please expand the tests to satisfy the 100% test coverage that packaging currently implements. |
|
Are there still plans to pull this? If you need help for expanding the test coverage, I could do that. |
|
@albertosottile I doubt I'll have time to look at this in the foreseeable future, so feel free to take this and fix it up! |
jimporter
force-pushed
the
legacy-specifier-set
branch
3 times, most recently
from
73d757c to
663da25
Compare
|
@brettcannon It looks like you've been doing reviews for this project lately. I think everything here is (finally) good to go, aside from maybe tweaking the type annotation stuff. I didn't look too hard at how Python type annotations work, so it's possible I'm doing a few things wrong there. |
pradyunsg
changed the title
|
@jimporter my reviews have been very much contained to a single module |
|
@brettcannon No worries! I know the feeling of neglecting other projects (which is why I had to put this PR aside for 3 years...). |
|
@pradyunsg Would you be the right person to review this? If not, feel free to unflag yourself and/or redirect to a better person. Thanks! |
|
I think so -- I'll take a look sometime early next week. Feel free to ping me if I don't though. :) |
jimporter
force-pushed
the
legacy-specifier-set
branch
from
0c72b4b to
f1893d5
Compare
jimporter
force-pushed
the
legacy-specifier-set
branch
from
f1893d5 to
3e4d297
Compare
|
@pradyunsg I totally forgot about this thanks to all the craziness from the pandemic, but this should be fixed up and ready to merge after a review. :) |
|
Closing this in light of #321. |
This creates a
LegacySpecifierSetclass that can be used for specifying version requirements when you know you haveLegacyVersions. I tried to make it similar to theVersion/LegacyVersionsplit, so it has a.prereleasesattribute, even though it doesn't do much with it.This should fix #74.