Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url based constraints #8757

Closed
thenewguy opened this issue Aug 13, 2020 · 1 comment
Closed

Url based constraints #8757

thenewguy opened this issue Aug 13, 2020 · 1 comment
Labels
resolution: duplicate Duplicate of an existing issue/PR

Comments

@thenewguy
Copy link

I've been issued a depreciation warning and found #8210

That issue is locked for commenting. We use constraints that point to tarball urls like https://github.com/some/repo/archive/bugfix-issue-foo.tar.gz#egg=somepackage

This conceptually is a constraint as it is just a bugfix of a public release that we do not control the upstream release process. This lets us point towards the fix until upstream releases a fix. We have many common packages and use a global constraint file to facilitate these fixes globally. Requiring a new requirement is unwarranted because it is typically temporary until upstream is able to act.

Removing this feature is very unfortunate. It saves a lot of error and duplication of work.

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Aug 13, 2020
@uranusjr
Copy link
Member

Merging into #8253. The feature will continue to exist, but likely offered in another way. #8210 was closed because it was decided that “nameless” constraints are not going to be allowed (although it does contain much discussion on named URL requirements). Feel free to contribute to the discussion, since we need to come to a conclusion before the resolver rollout is done.

Also, thanks for reaching out to say this is a feature used in the real-world! The biggest concern we had discussing this topic was the use case seems too hypothetical. It would greatly affect the decision process if we have concrete use cases to the feature at hand.

@uranusjr uranusjr added the resolution: duplicate Duplicate of an existing issue/PR label Aug 13, 2020
@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label Feb 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution: duplicate Duplicate of an existing issue/PR
Projects
None yet
Development

No branches or pull requests

3 participants