Fix parsing of verify_ssl=false in urls with authentication in Pipfile

[Enzime]

pipenv breaks when the first specified source in the Pipfile contains a username and password.

[Enzime]

Can someone post what the buildkite says is failing?

[techalchemy]

Sorry I’m out of town due to a family emergency and only me and Kenneth have accesss. If you remind me in a day I can check for you or you can run the build on a Linux vm if you didn’t already to find out. I can tell you that it builds python 2.7 first and that’s likely what failed

[Enzime]

@techalchemy are you able to post the error output now?

[uranusjr]

Not from Buildkite, but these are the errors I got

================================================ ERRORS =================================================
_______________________________ ERROR collecting tests/unit/test_utils.py _______________________________
tests/unit/test_utils.py:129: in <module>
    class TestUtils:
tests/unit/test_utils.py:378: in TestUtils
    verify_ssl: False,
E   NameError: name 'verify_ssl' is not defined
_______________________________ ERROR collecting tests/unit/test_utils.py _______________________________
tests/unit/test_utils.py:129: in <module>
    class TestUtils:
tests/unit/test_utils.py:378: in TestUtils
    verify_ssl: False,
E   NameError: name 'verify_ssl' is not defined
_______________________________ ERROR collecting tests/unit/test_utils.py _______________________________
tests/unit/test_utils.py:129: in <module>
    class TestUtils:
tests/unit/test_utils.py:378: in TestUtils
    verify_ssl: False,
E   NameError: name 'verify_ssl' is not defined
_______________________________ ERROR collecting tests/unit/test_utils.py _______________________________
tests/unit/test_utils.py:129: in <module>
    class TestUtils:
tests/unit/test_utils.py:378: in TestUtils
    verify_ssl: False,
E   NameError: name 'verify_ssl' is not defined

Looks like you missed some quotes in your test fixture.

[Enzime]

@uranusjr Thanks, fixed.

[techalchemy]

Thanks for the contribution! I don't really have any concerns here, looks pretty good to me

[Enzime]

This bug wasn't a result of verify_ssl being false it was because the source contained a username and password.

[uranusjr]

Feel free to rewrite the fragment if you feel it is incorrect!

[techalchemy]

I mean, while the bug may not be caused by verify_ssl being false (I didn't say that it was caused by setting verify_ssl = false, only that it sometimes occurred when parsing URLs which specified this option), it can certainly only apply to URLs that specify verify_ssl = false as I mention in the news fragment, wouldn't you say?

Fixed a bug which sometimes caused pipenv to parse the trusted_host argument to pip incorrectly

This is the nature of the bug, no?

parsing source URLs which specify verify_ssl = false.

This is a condition under which the bug occurs, right? I didn't want to get super detailed, as it's most likely an edge case that most users won't encounter -- there is a bug parsing the trusted host argument sometimes if you specify the argument via your pipfile. There are other ways to specify trusted hosts, but this is the only one that is handled by pipenv directly, so it seems relevant to caveat this by highlighting the specific context without delving into the low level, 'if you first type x, then y, then z, then put a thing here, etc'.

[Enzime]

Sorry, I got totally confused about the nature of the bug, after taking a look at the code again and remembering what the bug is. I totally agree with what you wrote.