WIP: Add spinner during locking #2993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
- Additional fix for #2981 Signed-off-by: Dan Ryan <dan@danryan.co>
Jamim
suggested changes
Oct 11, 2018
pipenv/core.py
Outdated
| @@ -1344,7 +1345,8 @@ def pip_install( | |||
| index_source = index_source.copy() | |||
| except SourceNotFound: | |||
| src_name = project.src_name_from_url(index) | |||
| verify_ssl = True if index not in trusted_hosts else False | |||
| index_url = parse_url(index) | |||
| verify_ssl = True if index_url.host not in trusted_hosts else False | |||
There was a problem hiding this comment.
I believe that the following form is enough:
verify_ssl = index_url.host not in trusted_hostsThere was a problem hiding this comment.
Indeed it is! thanks for the feedback :)
There was a problem hiding this comment.
bigger fish to fry on this one -- VCS installs are throwing permissions errors :(
pipenv/core.py
Outdated
| @@ -1355,7 +1357,8 @@ def pip_install( | |||
| extra_src = project.find_source(idx) | |||
| except SourceNotFound: | |||
| src_name = project.src_name_from_url(idx) | |||
| verify_ssl = True if idx not in trusted_hosts else False | |||
| src_url = parse_url(idx) | |||
| verify_ssl = True if src_url.host not in trusted_hosts else False | |||
There was a problem hiding this comment.
verify_ssl = src_url.host not in trusted_hostsSigned-off-by: Dan Ryan <dan@danryan.co>
…nes on windows Signed-off-by: Dan Ryan <dan@danryan.co>
- Update vendored deps - Fix minor bugs Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
changed the title
|
Closing, I have a better implementation of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Ryan dan@danryan.co