From e8ab9211fc4ab7a2b71ed7785593db92cb3a5b47 Mon Sep 17 00:00:00 2001 From: geisserml Date: Thu, 11 May 2023 14:08:29 +0200 Subject: [PATCH] Minor code comment fixes --- setupsrc/pypdfium2_setup/packaging_base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setupsrc/pypdfium2_setup/packaging_base.py b/setupsrc/pypdfium2_setup/packaging_base.py index 627aab437..c408bc299 100644 --- a/setupsrc/pypdfium2_setup/packaging_base.py +++ b/setupsrc/pypdfium2_setup/packaging_base.py @@ -40,7 +40,7 @@ import ctypesgen except ImportError: # ctypesgen not importable, might be installed on a different python version - # in that case, we don't if it's our fork, so assume mainline ctypesgen for compatibility + # in that case, we don't know if it's our fork, so assume mainline ctypesgen for compatibility CTYPESGEN_IS_FORK = False else: CTYPESGEN_IS_FORK = getattr(ctypesgen, "PYPDFIUM2_SPECIFIC", False) @@ -96,7 +96,7 @@ class PlatformNames: def plat_to_system(pl_name): if pl_name == PlatformNames.sourcebuild: - # NOTE If doing a sourcebuild on an unknown host system, this returns None, which will cause binary detection code to fail (we need to know the platform-specific binary name). + # FIXME If doing a sourcebuild on an unknown host system, this returns None, which will cause binary detection code to fail (we need to know the platform-specific binary name) - handle this upstream with fallback value? return Host.system result = [s for s in BinarySystems if pl_name.startswith(s)] assert len(result) == 1