Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review test code for possible missing asserts to comparisons #209

Closed
mara004 opened this issue Apr 20, 2023 · 1 comment
Closed

Review test code for possible missing asserts to comparisons #209

mara004 opened this issue Apr 20, 2023 · 1 comment
Assignees
@mara004
Labels
informational Reminders or considerations, including interesting ideas that might not be relevant/constructive

Comments

@mara004
Copy link
Member

mara004 commented Apr 20, 2023 •
edited
Loading

In #207 we discovered a mistake with a missing assert to a comparison. We may want to check there aren't more such cases.
@mara004 mara004 self-assigned this Apr 20, 2023
@mara004 mara004 changed the title Review test code for missing asserts Review test code for possible missing asserts Apr 20, 2023
@mara004 mara004 changed the title Review test code for possible missing asserts Review test code for possible missing asserts to comparisons Apr 20, 2023
@mara004 mara004 added the informational Reminders or considerations, including interesting ideas that might not be relevant/constructive label Aug 26, 2023
@mara004
Copy link
Member Author

mara004 commented Dec 7, 2023

Closing as acknowledged. Will get back to it with the next support model / test suite overhaul.

@mara004 mara004 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mara004 mara004

Labels
informational Reminders or considerations, including interesting ideas that might not be relevant/constructive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mara004