Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: fix set colorspace with new settings #1386

Merged
merged 6 commits into from
Apr 27, 2021

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented Apr 21, 2021

Closes #1375

  • Fixing the way nuke lib is getting settings data for image properties from Anatomy ImageIO
  • Fixing the nuke.api.lib module header self variable name to opnl because it was colliding with WorkfileSettings class and its sub function self variable.
  • Implementing forgotten ImageIO Setting's attribute Viewer
  • The new required input data attribute creator had to be added into a created OpenPypeData attributes for later use in filtering by a plugin name.

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 373, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

@jakubjezek001 jakubjezek001 marked this pull request as ready for review April 22, 2021 15:58
@jakubjezek001 jakubjezek001 requested a review from a team April 22, 2021 15:59
@jakubjezek001 jakubjezek001 self-assigned this Apr 22, 2021
@jakubjezek001 jakubjezek001 added type: bug Something isn't working host: Nuke labels Apr 22, 2021
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work quite well for me. The only thing I'm not sure about is the callback that should be setting on the launch of nuke, that is not working for me.

@mkolar
Copy link
Member

mkolar commented Apr 26, 2021

@jezscha shall we deal with the startup setting in a different PR?

@mkolar mkolar merged commit 3e7706a into develop Apr 27, 2021
@mkolar mkolar deleted the bugfix/1375-nuke-fix-set-colorspace-with-new-settings branch April 27, 2021 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke: fix set colorspace with new settings
2 participants