Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings actions process fix #1457

Merged
merged 4 commits into from
May 4, 2021
Merged

Conversation

iLLiCiTiT
Copy link
Member

Issue

  • settings actions on entities may not be processed on dynamic items
    • currently known issues are with strict list item which does not process any of actions properly
    • settings actions are discard changes, add to studio/project overrides and remove from studio/project overrides
  • issue started with Faster settings actions #1446 where was added validation before action process but the validation also skip all dynamic items

Changes

  • action validations were split into 2 parts:
    1. action can be triggered on entity - kept to check if action process can start on entity (and can show action in gui on entity)
    2. action can be processed on entity - any parent triggered action and entity have to handle the changes

@iLLiCiTiT iLLiCiTiT self-assigned this May 4, 2021
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label May 4, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 4, 2021 08:30
@mkolar mkolar merged commit 7afdbbc into develop May 4, 2021
@mkolar mkolar deleted the bugfix/settings_actions_process_fix branch May 4, 2021 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants