Maya schemas cleanup #1610

iLLiCiTiT · 2021-05-28T17:59:40Z

Changes

use advantage of templates where possible
converted template_maya_capture to schema_maya_capture as it's used at one place (and that probably won't change)

hound · 2021-05-31T22:20:48Z

openpype/hosts/maya/api/lib.py

@@ -2156,6 +2156,10 @@ def load_capture_preset(path=None, data=None):
    for key in preset['Display Options']:
        if key.startswith('background'):
            disp_options[key] = preset['Display Options'][key]
+            disp_options[key][0] = (float(disp_options[key][0])/255)
+            disp_options[key][1] = (float(disp_options[key][1])/255)
+            disp_options[key][2] = (float(disp_options[key][2])/255)


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:48Z

openpype/hosts/maya/api/lib.py

@@ -2156,6 +2156,10 @@ def load_capture_preset(path=None, data=None):
    for key in preset['Display Options']:
        if key.startswith('background'):
            disp_options[key] = preset['Display Options'][key]
+            disp_options[key][0] = (float(disp_options[key][0])/255)
+            disp_options[key][1] = (float(disp_options[key][1])/255)


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:48Z

openpype/hosts/maya/api/lib.py

@@ -2156,6 +2156,10 @@ def load_capture_preset(path=None, data=None):
    for key in preset['Display Options']:
        if key.startswith('background'):
            disp_options[key] = preset['Display Options'][key]
+            disp_options[key][0] = (float(disp_options[key][0])/255)


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:48Z

openpype/hosts/maya/plugins/load/load_ass.py

-                             c[0], c[1], c[2])
+                    (float(c[0])/256),
+                    (float(c[1])/256),
+                    (float(c[2])/256)


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:48Z

openpype/hosts/maya/plugins/load/load_ass.py

@@ -81,7 +81,10 @@ def process_reference(self, context, name, namespace, options):
            if c is not None:
                cmds.setAttr(groupName + ".useOutlinerColor", 1)
                cmds.setAttr(groupName + ".outlinerColor",
-                             c[0], c[1], c[2])
+                    (float(c[0])/256),
+                    (float(c[1])/256),


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:49Z

openpype/hosts/maya/plugins/load/load_vdb_to_redshift.py

@@ -62,7 +62,10 @@ def load(self, context, name=None, namespace=None, data=None):
        if c is not None:
            cmds.setAttr(root + ".useOutlinerColor", 1)
            cmds.setAttr(root + ".outlinerColor",
-                         c[0], c[1], c[2])
+                (float(c[0])/256),


continuation line under-indented for visual indent
missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:49Z

openpype/hosts/maya/plugins/load/load_vrayscene.py

-                         c[0], c[1], c[2])
+                (float(c[0])/256),
+                (float(c[1])/256),
+                (float(c[2])/256)


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:49Z

openpype/hosts/maya/plugins/load/load_vrayscene.py

@@ -53,7 +53,10 @@ def load(self, context, name, namespace, data):
        if c is not None:
            cmds.setAttr("{0}.useOutlinerColor".format(group_node), 1)
            cmds.setAttr("{0}.outlinerColor".format(group_node),
-                         c[0], c[1], c[2])
+                (float(c[0])/256),
+                (float(c[1])/256),


missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:50Z

openpype/hosts/maya/plugins/load/load_vrayscene.py

@@ -53,7 +53,10 @@ def load(self, context, name, namespace, data):
        if c is not None:
            cmds.setAttr("{0}.useOutlinerColor".format(group_node), 1)
            cmds.setAttr("{0}.outlinerColor".format(group_node),
-                         c[0], c[1], c[2])
+                (float(c[0])/256),


continuation line under-indented for visual indent
missing whitespace around arithmetic operator

hound · 2021-05-31T22:20:50Z

openpype/hosts/maya/plugins/load/load_yeti_cache.py

-                         c[0], c[1], c[2])
+                (float(c[0])/256),
+                (float(c[1])/256),
+                (float(c[2])/256)


missing whitespace around arithmetic operator

iLLiCiTiT added 4 commits May 28, 2021 19:06

use single template_color template in maya loader to achieve same result

8ee36b1

removed double colon from template_color label

db4f564

usa magic of templates in maya capture schema

8fc725f

changed template_maya_capture to schema_maya_capture

73fd71b

iLLiCiTiT self-assigned this May 28, 2021

iLLiCiTiT requested a review from a team May 28, 2021 17:59

mkolar added 2 commits May 31, 2021 23:34

convert maya color to new color widget

3585390

use color widget in maya playblast

ceb0d8b

hound bot reviewed May 31, 2021

View reviewed changes

mkolar approved these changes May 31, 2021

View reviewed changes

mkolar merged commit d0e50fb into develop May 31, 2021

mkolar deleted the feature/maya_schemas_cleanup branch May 31, 2021 22:21

mkolar added this to the 3.0.0 milestone May 31, 2021

mkolar added the type: enhancement Enhancements to existing functionality label May 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maya schemas cleanup #1610

Maya schemas cleanup #1610

iLLiCiTiT commented May 28, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

hound bot May 31, 2021

Maya schemas cleanup #1610

Maya schemas cleanup #1610

Conversation

iLLiCiTiT commented May 28, 2021

Changes

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment

hound bot May 31, 2021

Choose a reason for hiding this comment