Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint Start Frame #1844

Merged
merged 5 commits into from
Jul 27, 2021
Merged

TVPaint Start Frame #1844

merged 5 commits into from
Jul 27, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 21, 2021

Description

It seems that TVPaint start frame of scene may affect frame indexes during rendering. So start frame should be used as offset for rendered frame indexes.

Changes

  • use scene start frame as offset for rendered frame indexes
  • added validator which validates if start frame is set to '0'
    • validator is turned off by default

How to test

  1. Open TVPaint and change start frame of scene to e.g. 2 (How to)
  2. Set MarkIn and MarkOut to match asset frame start/end
  3. On each frame add different image so they are easily identified (e.g. paint numbers on them)
  4. Create render layer/pass
  5. Publish all of that and review
  6. Check if rendered frames match frames from scene
OpenPype 2 PRs
OpenPype #1839

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 21, 2021
@iLLiCiTiT iLLiCiTiT added backend type: enhancement Enhancements to existing functionality host: TV Paint labels Jul 21, 2021
@iLLiCiTiT iLLiCiTiT requested a review from 64qam July 21, 2021 16:09
@iLLiCiTiT iLLiCiTiT added the LOW label Jul 21, 2021
@iLLiCiTiT iLLiCiTiT mentioned this pull request Jul 21, 2021
@iLLiCiTiT iLLiCiTiT merged commit 7f1e872 into develop Jul 27, 2021
@mkolar mkolar deleted the feature/tvpaint_start_frame branch August 10, 2021 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: TV Paint type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants