Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

SFTP provider #2073

Merged
merged 10 commits into from
Oct 1, 2021
Merged

SFTP provider #2073

merged 10 commits into from
Oct 1, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Sep 24, 2021

Implemented SFTP provider for Site Sync.

Testing SFTP server spun up on AWS, check keeper for 'SFTP test'.

Testing configuration
sftp_settings
sftp_settings_local

@kalisp kalisp added type: enhancement Enhancements to existing functionality module: Sitesync labels Sep 24, 2021
@kalisp kalisp self-assigned this Sep 24, 2021
@mkolar
Copy link
Member

mkolar commented Sep 24, 2021

Task linked: PYPE-1930 Create SFTP provider

},
# roots could be overriden only on Project leve, User cannot
{
'key': "roots",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line over-indented for hanging indent

@kalisp kalisp marked this pull request as ready for review September 27, 2021 11:40
@kalisp kalisp requested review from 64qam and mkolar September 27, 2021 12:00
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but the Addons must not be configured. The synchronization will not work (upload will be stalled).

@mkolar mkolar added type: feature Larger, user affecting changes and completely new things and removed type: enhancement Enhancements to existing functionality labels Oct 1, 2021
@mkolar
Copy link
Member

mkolar commented Oct 1, 2021

@kalisp can we please resolve the poetry.lock conflict?

@kalisp
Copy link
Member Author

kalisp commented Oct 1, 2021

Conflict resolved, added some documentation.

@kalisp kalisp merged commit 2f1b0e3 into develop Oct 1, 2021
@kalisp kalisp deleted the PYPE-1930_Create-SFTP-provider branch October 1, 2021 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Sitesync type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants