This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for future, PR wasnt merged yet
kalisp
added
type: enhancement
Enhancements to existing functionality
module: Sitesync
labels
Sep 24, 2021
Task linked: PYPE-1930 Create SFTP provider |
}, | ||
# roots could be overriden only on Project leve, User cannot | ||
{ | ||
'key': "roots", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation line over-indented for hanging indent
64qam
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but the Addons must not be configured. The synchronization will not work (upload will be stalled).
mkolar
added
type: feature
Larger, user affecting changes and completely new things
and removed
type: enhancement
Enhancements to existing functionality
labels
Oct 1, 2021
@kalisp can we please resolve the poetry.lock conflict? |
Conflict resolved, added some documentation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SFTP provider for Site Sync.
Testing SFTP server spun up on AWS, check keeper for 'SFTP test'.
Testing configuration