Hiero: python3 compatibility #2365
Conversation
- converting single quotation to double - converting py2 prints to py3
|
Task linked: OP-1629 Hiero 13 compatibility |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| return | ||
|
|
||
| # The data model of the QTreeView | ||
| model = spreadsheetTreeView.model() | ||
|
|
||
| csvSavePath = os.path.join(QDir.homePath(), 'Desktop', | ||
| seq.name() + '.csv') | ||
| csvSavePath = os.path.join(QDir.homePath(), "Desktop", |
There was a problem hiding this comment.
'QDir' may be undefined, or defined from star imports: PySide.QtCore, PySide.QtGui, PySide2.QtCore, PySide2.QtGui, PySide2.QtWidgets
| def selectionChanged(event): | ||
| hiero.selection = event.sender.selection() | ||
|
|
||
| hiero.core.events.registerInterest("kSelectionChanged", selectionChanged) |
There was a problem hiding this comment.
expected 2 blank lines after class or function definition, found 1
| @@ -23,7 +23,7 @@ def __init__(self): | |||
| self.triggered.connect(self.PurgeUnused) | |||
| hiero.core.events.registerInterest("kShowContextMenu/kBin", | |||
| self.eventHandler) | |||
| self.setIcon(QIcon('icons:TagDelete.png')) | |||
| self.setIcon(QIcon("icons:TagDelete.png")) | |||
There was a problem hiding this comment.
'QIcon' may be undefined, or defined from star imports: PySide.QtCore, PySide.QtGui, PySide2.QtCore, PySide2.QtGui, PySide2.QtWidgets
| selectedBinItems = [bi.activeItem() for bi in self._selection if (isinstance(bi,hiero.core.BinItem) and hasattr(bi,'activeItem'))] | ||
|
|
||
| selectedBinItems = [bi.activeItem() for bi in self._selection if (isinstance(bi,hiero.core.BinItem) and hasattr(bi,"activeItem"))] |
There was a problem hiding this comment.
line too long (135 > 79 characters)
missing whitespace after ','
multiple spaces before operator
|
|
||
| self.menuActions += [makeAction( | ||
| "Custom...", self.setFrameRateFromMenuSelection, icon=None) | ||
| ] |
There was a problem hiding this comment.
continuation line under-indented for hanging indent
| self.menuActions+=[makeAction('Custom...',self.setFrameRateFromMenuSelection, icon=None)] | ||
|
|
||
| self.menuActions += [makeAction( | ||
| "Custom...", self.setFrameRateFromMenuSelection, icon=None) |
There was a problem hiding this comment.
continuation line under-indented for hanging indent
| self.menuActions = [] | ||
|
|
||
| def createFrameRateMenus(self,selection): | ||
| selectedClipFPS = [str(bi.activeItem().framerate()) for bi in selection if (isinstance(bi,hiero.core.BinItem) and hasattr(bi,'activeItem'))] | ||
| selectedClipFPS = [str(bi.activeItem().framerate()) for bi in selection if (isinstance(bi,hiero.core.BinItem) and hasattr(bi,"activeItem"))] |
There was a problem hiding this comment.
line too long (145 > 79 characters)
missing whitespace after ','
multiple spaces before operator
| @@ -88,13 +88,13 @@ def __init__(self): | |||
|
|
|||
|
|
|||
| # ant: Could use hiero.core.defaultFrameRates() here but messes up with string matching because we seem to mix decimal points | |||
| self.frameRates = ['8','12','12.50','15','23.98','24','25','29.97','30','48','50','59.94','60'] | |||
| self.frameRates = ["8","12","12.50","15","23.98","24","25","29.97","30","48","50","59.94","60"] | |||
There was a problem hiding this comment.
indentation is not a multiple of four
line too long (101 > 79 characters)
missing whitespace after ','
testing: