Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Global: fix broken otio review extractor #2590

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

jakubjezek001
Copy link
Member

Brief description

Fault range creation when source frame 0

Description

When media source first frame was 0 we didn't need to add 1 frame to duration.

Testing notes:

  1. open your testing project in hiero
  2. add a clip to main layer with handles at start 0 end 5 (make sure sequence is having available frames in tail)
  3. add video file with no handles and tails under to review so it will be reviewable
  4. create publishable clip and set workfile start frame to 992 for example and handles 0-5
  5. publish with review ON
    Frame range should work as expected.

@jakubjezek001 jakubjezek001 self-assigned this Jan 25, 2022
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Jan 25, 2022
@mkolar
Copy link
Member

mkolar commented Jan 25, 2022

Task linked: OP-2512 hiero publishing problem

@jakubjezek001 jakubjezek001 merged commit 656e6d4 into develop Feb 1, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/hiero-otio-review-publishing branch February 1, 2022 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants