-
Notifications
You must be signed in to change notification settings - Fork 129
Ftrack: Family to Asset type mapping is in settings #2602
Ftrack: Family to Asset type mapping is in settings #2602
Conversation
Aside of allowing customizing the family mapping this also now allows to enable/disable the Plugin itself in admin settings, correct? Is that something we want or could that cause problems if someone would disable the |
Yes, there's an enable/disable switch as well. I followed the pattern of the other FTrack plugin settings, but of course it can be removed. |
Maybe @mkolar or @iLLiCiTiT can give us some guide? |
I am not sure about disabling IntegrateFtrackInstance. I guess it is integral part of ftrack module and you either want the whole ftrack module enabled or have it completely disabled? Of course, this cannot be done per project level so with this you could control it on project level, but the use case would be pretty niche I suppose. |
There should not be enable checkbox on this plugin. If you want to disable ftrack per project you can "not add" ftrack families in Collect Ftrack Family. |
Roger, checkbox removed and added more defaults, now all current OpenPype families are mapped. The exception is "Render", but it is never synced to FTrack. |
Please don't use tabs but 4 spaces and do not save default values modifying the file but use settings tool to do so. |
Done. |
:) Check changes you've made in this PR. You've added space after all keys in the schema |
Yep, sorry for the formatting changes. I actually saved the defaults from the settings editor, but copy/pasted the content of the file into the github editor to commit. I'll install some IDE soon to do proper commits, I just wanted to create a quick patch for now. I hope the formatting is ok now. |
Sorry again for the mess, I corrected all the formatting differences by hand for now. |
Brief description
Added missing Family Mapping settings