Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: Family to Asset type mapping is in settings #2602

Merged
merged 12 commits into from
Feb 2, 2022
Merged

Ftrack: Family to Asset type mapping is in settings #2602

merged 12 commits into from
Feb 2, 2022

Conversation

gabormarinov
Copy link
Contributor

Brief description

Added missing Family Mapping settings

@BigRoy
Copy link
Collaborator

BigRoy commented Jan 28, 2022

Aside of allowing customizing the family mapping this also now allows to enable/disable the Plugin itself in admin settings, correct?

Is that something we want or could that cause problems if someone would disable the IntegrateFtrackInstance plugin?

@gabormarinov
Copy link
Contributor Author

gabormarinov commented Jan 28, 2022

Yes, there's an enable/disable switch as well. I followed the pattern of the other FTrack plugin settings, but of course it can be removed.

@gabormarinov
Copy link
Contributor Author

Maybe @mkolar or @iLLiCiTiT can give us some guide?

@antirotor
Copy link
Member

I am not sure about disabling IntegrateFtrackInstance. I guess it is integral part of ftrack module and you either want the whole ftrack module enabled or have it completely disabled? Of course, this cannot be done per project level so with this you could control it on project level, but the use case would be pretty niche I suppose.

@antirotor antirotor added module: Ftrack type: enhancement Enhancements to existing functionality labels Jan 28, 2022
@iLLiCiTiT
Copy link
Member

There should not be enable checkbox on this plugin. If you want to disable ftrack per project you can "not add" ftrack families in Collect Ftrack Family.

@gabormarinov
Copy link
Contributor Author

gabormarinov commented Jan 29, 2022

Roger, checkbox removed and added more defaults, now all current OpenPype families are mapped. The exception is "Render", but it is never synced to FTrack.

@iLLiCiTiT
Copy link
Member

Please don't use tabs but 4 spaces and do not save default values modifying the file but use settings tool to do so.

@gabormarinov
Copy link
Contributor Author

Done.

@iLLiCiTiT
Copy link
Member

:) Check changes you've made in this PR. You've added space after all keys in the schema {"key" : "value"} which should be {"key": "value"} this is most likely style agreement we have and would be good to keep it consistent (and not change). Also you've manually saved the file with default values. I know that because of the change of last line in openpype/settings/defaults/project_settings/ftrack.json. If possible don't change json files with default values manually.

@gabormarinov
Copy link
Contributor Author

Yep, sorry for the formatting changes. I actually saved the defaults from the settings editor, but copy/pasted the content of the file into the github editor to commit. I'll install some IDE soon to do proper commits, I just wanted to create a quick patch for now. I hope the formatting is ok now.

@gabormarinov
Copy link
Contributor Author

Sorry again for the mess, I corrected all the formatting differences by hand for now.

@iLLiCiTiT iLLiCiTiT changed the title Enhancement/ftrack family mapping settings Ftrack: Family to Asset type mapping is in settings Feb 2, 2022
@iLLiCiTiT iLLiCiTiT merged commit 4ce12ff into ynput:develop Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Ftrack type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants