-
Notifications
You must be signed in to change notification settings - Fork 129
Deadline: Simplify GlobalJobPreLoad logic #2605
Conversation
OpenPypeExecutable setting is now retrieved from the OpenPype Plug-in instead.
I am all up for removing the event, I really hated it anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please purge all mentions of DL event in vendor/readme.md
and website/docs/module_deadline.md
?
Sure can! Like this? |
Any chance we can get the Build/Docs deployment to run again @kalisp @mkolar ?
(Copied from Discord) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
I will keep it unmerged for now to not hide issue with documentation build. After that I would merge it.
It should indeed work now, but you need to merge develop to this branch. Github actions are picked from currently checked out branch. |
@mkolar Now the check suddenly is gone and thus no documentation build is checked? |
Lets merge this one and observe next PRs. |
Brief description
This simplifies the logic the Deadline plug-in requires to retrieve the OpenPype Executable.
Would love to hear whether this would move it in a good direction or whether this is not preferred?
The Event Plug-in also had some "ftrack" related functions which was basically doing nothing currently. I'm not sure if there might be customers out there how do have that logic altered instead and thus the Event Plug-in might still have a place. Something to consider at least.