Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Fix menu callbacks #2671

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Maya: Fix menu callbacks #2671

merged 1 commit into from
Feb 8, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

PR #2649 broke Maya menu callbacks.

Changes

  • menu callbacks are passed using lambda to avoid passing unexpected arguments to registered functions

Testing notes:

  1. Open Maya using OpenPype
  2. Try run Reset resolution, Reset frame range or Set colorspace

@iLLiCiTiT iLLiCiTiT changed the title fix menu callbacks to use lambda to avoid passing unexpected arguments Maya: Fix menu callbacks Feb 8, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Feb 8, 2022
@iLLiCiTiT iLLiCiTiT added host: Maya type: bug Something isn't working labels Feb 8, 2022
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all three functions are working in Maya now.

only Reset Resolution is giving some feedback in script editor though.

# openpype.hosts.maya.api.lib : Setting scene resolution to: 1920 x 1080 #

antirotor
antirotor approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@antirotor antirotor merged commit f483ee7 into develop Feb 8, 2022
@antirotor antirotor deleted the bugfix/maya_menu_callbacks branch February 8, 2022 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antirotor antirotor antirotor approved these changes

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
host: Maya type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @m-u-r-p-h-y @antirotor