Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Houdini: Move Houdini Save Current File to beginning of ExtractorOrder #2747

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Feb 16, 2022

Brief description

In the spirit of this PR #2744 with this commit moving the order for the Save Scene plug-ins to beginning of ExtractorOrder this makes Houdini align with that too.

As discussed in the comments this seemed like the more sensible moment to save the current workfile.

Additional note

In Houdini there seemed to be two plug-ins involved with saving - one operating at a different target for different families.
We could technically add both in a single file and do something like:

class SaveCurrentScene(pyblish.api.ContextPlugin):
    """Save current scene"""

    label = "Save current file"
    order = pyblish.api.ExtractorOrder - 0.49
    hosts = ["houdini"]
    targets = ["deadline"]

    def process(self, context):
        ...

# Inherit from SaveCurrentScene to always save for all families for target `deadline`
class SaveCurrentSceneDeadline(SaveCurrentScene):
    hosts = ["houdini"]
    targets = ["deadline"]

That way the logic could be less duplicated and the Save plug-ins close together.

@BigRoy BigRoy changed the title Move Houdini Save Current File to beginning of ExtractorOrder Houdini: Move Houdini Save Current File to beginning of ExtractorOrder Feb 16, 2022
@antirotor
Copy link
Member

Shouldn't we add more families there, or maybe use it for all of them?

@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 18, 2022

Shouldn't we add more families there, or maybe use it for all of them?

Quickly checked with our Houdini artist - he had no issue with scene being saved on all families by default. We can always tone that down if we notice issues with that approach.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 21, 2022

or maybe use it for all of them?

Implemented with 7de42ee

@antirotor antirotor merged commit ebd2795 into ynput:develop Feb 22, 2022
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Mar 4, 2022
@mkolar mkolar added this to the 3.9.0 milestone Mar 15, 2022
@BigRoy BigRoy deleted the hou_move_save_current_file_to_extractororder branch March 20, 2024 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Houdini type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants