This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
StandalonePublisher: removed Extract Background plugins #3093
Merged
+2
−733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: OP-3113 SAP: ExtractBGMainGroups |
Should be converted into add-on. |
Plugins were only for specific customer (and not working because of missing psd-tools).
kalisp
force-pushed
the
chore/OP-3113_SAP-ExtractBGMainGroups
branch
from
April 26, 2022 14:55
0b83391
to
604263b
Compare
Converted to Addon. |
64qam
suggested changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not working for multiple files and psd-tools
is not installed from addons
I reckon this can be closed and review in the addon repon, correct? @kalisp |
…3113_SAP-ExtractBGMainGroups
…3113_SAP-ExtractBGMainGroups
psd_tools requires it
kalisp
changed the title
StandalonePublisher: added support for Extract Background families
StandalonePublisher: removed Extract Background plugins
May 6, 2022
Task type enum is dynamically created from Ftrack, value here is targeted only for single customer, so it shouldn't probably be in defaults at all.
64qam
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Extract Background Layout
andExtract Background Comp
support was missing from 2.xDescription
Necessary plugins were moved to separate AddOn as this functionality is customer specific.
Build itself need to contain
dataclasses
as library used in an addon requires them and vendorizying it doesn't work.