Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

StandalonePublisher: removed Extract Background plugins #3093

Merged
merged 6 commits into from
May 10, 2022

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Apr 22, 2022

Brief description

Extract Background Layout and Extract Background Comp support was missing from 2.x

Description

Necessary plugins were moved to separate AddOn as this functionality is customer specific.
Build itself need to contain dataclasses as library used in an addon requires them and vendorizying it doesn't work.

@kalisp kalisp requested a review from 64qam April 22, 2022 15:40
@kalisp kalisp self-assigned this Apr 22, 2022
@ynbot
Copy link
Contributor

ynbot commented Apr 22, 2022

Task linked: OP-3113 SAP: ExtractBGMainGroups

@kalisp kalisp marked this pull request as draft April 25, 2022 13:28
@kalisp
Copy link
Member Author

kalisp commented Apr 25, 2022

Should be converted into add-on.

Plugins were only for specific customer (and not working because of missing psd-tools).
@kalisp kalisp force-pushed the chore/OP-3113_SAP-ExtractBGMainGroups branch from 0b83391 to 604263b Compare April 26, 2022 14:55
@kalisp kalisp marked this pull request as ready for review April 26, 2022 14:57
@kalisp
Copy link
Member Author

kalisp commented Apr 26, 2022

Converted to Addon.

Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not working for multiple files and psd-tools is not installed from addons

@mkolar
Copy link
Member

mkolar commented Apr 28, 2022

I reckon this can be closed and review in the addon repon, correct? @kalisp

@kalisp kalisp changed the title StandalonePublisher: added support for Extract Background families StandalonePublisher: removed Extract Background plugins May 6, 2022
@kalisp kalisp requested a review from 64qam May 6, 2022 14:19
Task type enum is dynamically created from Ftrack, value here is targeted only for single customer, so it shouldn't probably be in defaults at all.
@kalisp kalisp merged commit a1c0179 into develop May 10, 2022
@kalisp kalisp deleted the chore/OP-3113_SAP-ExtractBGMainGroups branch May 10, 2022 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants