This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Settings: Remove environment groups from settings #3115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Removed logic related to environment groups which were implemented at the beginning of settings implementation but are not used anymore.
Description
Environment groups were stored using metadata to easily find their values in whole settings but the approach had a lot of limitations and was more magical then practical. Goal of PR is to make clearer api and remove unused code (that should not be used). All removed functions were kept for backwards compatibility of older builds but it is not needed for more then 2 minor releases. Also removed backwards compatibily of removed functions from
start.py
.Additional info
Removed functions
openpype.lib.env_tools.get_global_environments
- was replaced byopenpype.settings.get_general_environments
openpype.settings.get_environments
- was replaced byopenpype.settings.get_general_environments
openpype.settings.lib.find_environments
- not used anymoreTesting notes: