Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Merge animation + pointcache extractor logic #3461

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jul 1, 2022

Brief description

This reduces duplicated code by merging the logic of Animation + Pointcache Extractor into a single file.

Testing notes:

  1. Pointcache and animation publishing should work like before

@mkolar mkolar requested review from mkolar and m-u-r-p-h-y July 5, 2022 06:11
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. Seem to work just fine.

@mkolar
Copy link
Member

mkolar commented Jul 5, 2022

Looks like there was some tweak in extract animation in develop, but I can't seem to track it down :/

@mkolar mkolar added the type: refactor Structural changes not affecting functionality label Jul 5, 2022
…ic_extractors

# Conflicts:
#	openpype/hosts/maya/plugins/publish/extract_animation.py
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jul 5, 2022

Looks like there was some tweak in extract animation in develop, but I can't seem to track it down :/

Couldn't really detect what it was either - I've merged latest develop and kept the file removed. Should be good.

@mkolar mkolar merged commit e8b62e3 into ynput:develop Jul 6, 2022
@BigRoy BigRoy deleted the maya_merge_alembic_extractors branch March 20, 2024 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants