Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Enable write color sets on animation publish automatically #3582

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Enable write color sets on animation publish automatically #3582

merged 6 commits into from
Aug 1, 2022

Conversation

moonyuet
Copy link
Member

Brief description

Add the switching on/off option for write color sets in Create Cache in Openpype settings
image

Description

Add the switching on/off option for write color sets in Create Cache in Openpype settings, which overrides the write color sets attributes in maya when creating point cache instance for the geometry.
It is implemented for being consistent regarding to the same implementation of switching on/off options in Create Animation for maya.

@moonyuet moonyuet mentioned this pull request Jul 27, 2022
Closed
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Animation and Point Cache instances are created with proper values set from settings.

I would suggest unifying the naming in settings though.

Cache -> Point Cache

(and fixing hound comments :)

image

@mkolar
Copy link
Member

mkolar commented Jul 27, 2022

@moonyuet I agree with Murphy. all good, just please fix the label and the hound comments.

@moonyuet
Copy link
Member Author

image
Get the name changed!

m-u-r-p-h-y
m-u-r-p-h-y approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ready to go . . .

@mkolar mkolar merged commit bf6485d into ynput:develop Aug 1, 2022
@moonyuet moonyuet deleted the Enable-write-color-sets-on-animation-publish-automatically branch December 13, 2022 02:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

Assignees

@moonyuet moonyuet

Labels
host: Maya
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonyuet @mkolar @m-u-r-p-h-y