This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Deadline: better logging for DL webservice failures #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some specific cases DL sends broken json payload even if response.ok. Handle parsing of broken json better.
In some specific cases DL sends broken json payload even if response.ok. Handle parsing of broken json better.
BigRoy
reviewed
Aug 18, 2022
BigRoy
reviewed
Aug 18, 2022
|
It's a tricky one. It's hard to tell what the culprit of the issue originally was and whether this PR will actually avoid the same confusion. The fact that this now also raises its own replacement error I wonder whether it might make it harder to debug in the future than just re-raising the error with |
iLLiCiTiT
reviewed
Aug 19, 2022
iLLiCiTiT
reviewed
Aug 19, 2022
Warning should print exception. JSONDecoder is not in Pype2
iLLiCiTiT
reviewed
Aug 19, 2022
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
approved these changes
Aug 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
It seems that DL webservice can return broken json payload even if
response.ok. Safer and saner report.Additional info
Without it error message is a bit vague:
Not sure how to test it properly. I would just try to send regular DL submission from AE (or Harmony).