Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Change publish template settings location #3755

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 29, 2022

Brief description

Publish templates (used for integration) are not defined on publish plugin settings but out of the integrator for both versioned and hero publishing.

Description

Settings for publish template resolving was moved to project_settings/global/tools/publish. Versioned publishing has key template_name_profiles and hero publishing has key hero_template_name_profiles. Code was changed in backwards compatible way: If values in new settings are empty the legacy settings source is used.

Additional info

Default settings of new locations are by default empty so the transition to new settings location can be smooth and won't cause lose and breaking changes. This way it is possible to transfer settings for existing projects one by one and they start to be used from new source only if new location is used.

The settings output for versioned templates is not exactly the same "tasks" key has changed to "task_names".

Transition process

Open settings UI. Repeat this on each individual project first, and keep "default project" as last.

  • If project_settings/global/publish/IntegrateHeroVersion/template_name_profiles is overriden (orange color for project/green color for default project) then copy the values and paste them to project_settings/global/tools/publish/hero_template_name_profiles.
  • If project_settings/global/publish/IntegrateAssetNew/template_name_profiles is overriden (orange color for project/green color for default project) then copy the values and paste them to project_settings/global/tools/publish/template_name_profiles -> WARNING: Task names will not be copied and must be copy -pasted individually.
  • changing this settings on default project will affect all projects that's why it is recommended to the transition on default project as last

Testing notes:

  • Without any change publish templates should be used from previous settings locations
  • When new settings in location are changed they should be taken from there

@ynbot
Copy link
Contributor

ynbot commented Aug 29, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 29, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Aug 29, 2022
@iLLiCiTiT iLLiCiTiT merged commit 31b4b3f into develop Sep 12, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3842_Change-publish-template-settings-location branch September 12, 2022 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants