Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General/TVPaint: Attribute defs dialog #4052

Merged
merged 10 commits into from
Nov 4, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Nov 1, 2022

Brief description

Attribute definitions have prepared dialog like qargparse have.

Description

First step to use Attribute definitions instead of qargparse in the code. Prepared dialog for attribute definitions to show qargparse like dialog. Loaders can use attribute definitions in get_options (or options) so the dialog is used in loaders. TVPaint loaders are using it. Also update loaders to implement get_options instead of using options so defaults from settings are properly propagated to options.

Additional info

Attribute definitions don't have available all options as qargparse had so we'll have to add missing implementations in future.

Why to replace qargparse?

Module qargparse is Qt based so it must have available Qt binding to be able import and create objects which will be problematic for detached UI workflow.

Testing notes:

  1. TVPaint loaders should be able to show options in loader
  2. Confirmed options dialog should do what did

@github-actions github-actions bot added this to the next-patch milestone Nov 1, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Nov 1, 2022
@iLLiCiTiT iLLiCiTiT added type: enhancement Enhancements to existing functionality host: TV Paint labels Nov 1, 2022
@iLLiCiTiT iLLiCiTiT merged commit d4ae2ac into develop Nov 4, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/attribute_defs_dialog branch November 4, 2022 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: TV Paint type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants