Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Maketx executable issue #4136

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Fix validation of maketx executable in maya.

Description

Extract look validated if executable returned from get_oiio_tools_path exists which did not on windows because of missing extension but that should not cause issues.

Additional info

We should fix the source issue in get_oiio_tools_path but that would require more time.

Testing notes:

  1. ExtractLook in Maya should work on windows

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 24, 2022
@iLLiCiTiT iLLiCiTiT added type: bug Something isn't working host: Maya labels Nov 24, 2022
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as expected on windows

image

@iLLiCiTiT iLLiCiTiT merged commit 4fcc181 into develop Nov 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/maketx_executable_issue branch November 24, 2022 16:02
@github-actions github-actions bot added this to the next-patch milestone Nov 24, 2022
@jakubjezek001 jakubjezek001 modified the milestones: 3.14.7, next-patch Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants