Maya: Maintain time connections on Alembic update. #4143
Conversation
openpype/hosts/maya/api/plugin.py
Outdated
| else: | ||
| cmds.setAttr(node_attr, data["value"]) |
There was a problem hiding this comment.
Doesn't updating the alembic automatically reconnect the time attribute and thus for us to set the value we'll first need to force disconnect it?
To test:
- Load alembic
- Disconnect time
- Set manually (so basically not reconnecting/keying it)
- Update alembic with this PR
Does that work as expected? Is time still disconnected and did it maintain the value that was set manually?
There was a problem hiding this comment.
Also, this would mean if you'd update without any changes to .time attribute it'd probably log a warning or error on update that time was already connected?
There was a problem hiding this comment.
You are right. Will have a look at this.
openpype/hosts/maya/api/plugin.py
Outdated
| data = { | ||
| "connected": False, | ||
| "attribute": None, | ||
| "value": cmds.getAttr(node_attr) | ||
| } | ||
| if connections: | ||
| data["connected"] = True | ||
| data["attribute"] = connections[0] |
There was a problem hiding this comment.
I feel like this could be rewritten to:
"input": next(iter((cmds.listConnections(node_attr, plugs=True, destinations=False) or []), None))
"value": cmds.getAttr(node_attr)
}
So basically no need to track connected + attribute separately since if input is None you know it wasn't connected. You can just store input (== attribute) as single value.
openpype/hosts/maya/api/plugin.py
Outdated
| @@ -226,7 +226,17 @@ def update(self, container, representation): | |||
| if alembic_nodes: | |||
| for attr in alembic_attrs: | |||
| node_attr = "{}.{}".format(alembic_nodes[0], attr) | |||
| alembic_data[attr] = cmds.getAttr(node_attr) | |||
| connections = cmds.listConnections(node_attr, plugs=True) | |||
There was a problem hiding this comment.
This should have argument destinations=False since otherwise it could also list outputs of the attribute.
LiborBatek
dismissed
their stale review
According to BigRoys comments not fully functional yet and changes needed
- account for time attribute reconnection. - simpler data collection
|
@BigRoy you happy with the PR? |
openpype/hosts/maya/api/plugin.py
Outdated
| if data["input"]: | ||
| cmds.connectAttr( | ||
| data["input"], node_attr, force=True | ||
| ) |
There was a problem hiding this comment.
Shouldn't this make sure that the connection to be made doesn't already exist? (is a warning issues when e.g. time was previously connected and you'd update (the update reconnects time by default) and thus this tries to connect time again even though already connected. Does that error or log a warning?
There was a problem hiding this comment.
note from testing side...it didnt reconnect time by default after updating the asset so no chance for any warning or error. If I am correct.
There was a problem hiding this comment.
note from testing side...it didnt reconnect time by default after updating the asset so no chance for any warning or error. If I am correct.
Thank you - so did it just always result in an unconnected attribute, even if you previously had it connected? :)
Doesn't it by default connect to time?
openpype/hosts/maya/api/plugin.py
Outdated
| inputs = cmds.listConnections( | ||
| node_attr, plugs=True, destination=False | ||
| ) |
There was a problem hiding this comment.
I feel the code would be more readable if we'd move this to a simple separate function:
def get_input(attr):
connections = cmds.listConnections(attr, plugs=True, destination=False)
return connections[0] if connections else NoneThe code here could then just be:
data = {
"input": get_input(node_attr),
"value": cmds.getAttr(node_attr)
}And further down would just be:
if alembic_nodes:
alembic_node = alembic_nodes[0] # assume single AlembicNode
for attr, data in alembic_data.items():
node_attr = "{}.{}".format(alembic_node, attr)
if data["input"]:
if data["input"] != get_input(node_attr):
cmds.connectAttr(
data["input"], node_attr, force=True
)
else:
input = get_input(node_attr)
if input:
cmds.disconnectAttr(input, node_attr)
cmds.setAttr(node_attr, data["value"])Anyway, just feels more readable to only me maybe.
|
@BigRoy what do you think now? |
Brief description
Maintain time connections on Alembic update.
Description
This maintains the connections to the time attribute on the alembic node in Maya so you can for example animate the time.
Additional info
The rest will be ignored in changelog and should contain any additional
technical information.
Documentation (add "type: documentation" label)
feature_documentation
Testing notes: