This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
feature/ftrack parent thumbnails #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tilix4
added a commit
to Tilix4/OpenPype
that referenced
this pull request
Jun 16, 2023
Tilix4
added a commit
to Tilix4/OpenPype
that referenced
this pull request
Aug 4, 2023
Tilix4
added a commit
to Tilix4/OpenPype
that referenced
this pull request
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
ThumbnailEvents handler now set, to created entity, thumbnail of it's parent. But parent's thumbnail at the time of creation may be default ftrack thumbnail. That cause strange behavior when publishing from nukestudio or premiere is happening. First are created entities and set their thumbnails, then are created new asset versions which are not connected to task but only it's parent. In that case tasks have different thumbnail than it's parent entity.
Solution:
Handler is skipping setting thumbnail if hierarchical entities at all. Ftrack provides populating thumbnails function which do what we need to do.