Bugfix/266 toggle instance in pyblish pype crashes

[iLLiCiTiT]

Issue:
setData method called in model cause TypeError: invalid result from InstanceItem.setData()

Solution:
Toggle setData method happens on item not on model.

Resolves: #266

[iLLiCiTiT]

This should be fixed in pyblish-lite too for client without 2.10 release.

[tokejepsen]

Not sure whether its related to this, but the callback instanceToggled does not seem to work.

    pyblish.api.register_callback(
        "instanceToggled", on_pyblish_instance_toggled
    )

[iLLiCiTiT]

Not sure whether its related to this, but the callback instanceToggled does not seem to work.

That is not related, but good to know. Just looked how it's implemented in pyblish-qml and it should be easy to implement here if necessary in next PR. But I don't see use case for that to be honest?

[tokejepsen]

But I don't see use case for that to be honest?

For example in Harmony you can persist the publish state to the scene so anyone picking up the scene afterwards will have the same enabled/disabled instances.
In Harmony this is done thought enabling/disabling nodes in the view.

[iLLiCiTiT]

In Harmony this is done thought enabling/disabling nodes in the view.

Create new issue, it should be easy to do.