Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Extract review a representation name with *_burnin #388

Closed
jakubjezek001 opened this issue Jul 28, 2020 · 3 comments · Fixed by #520
Closed

Extract review a representation name with *_burnin #388

jakubjezek001 opened this issue Jul 28, 2020 · 3 comments · Fixed by #520
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@jakubjezek001
Copy link
Member

Describe the bug
Some hosts (maya) are creating published represetation names with _burnin and it is creating inconsistency in Loader plugin representation filters.

Expected behavior
All representations across pipeline should have the same name defined from name of Exctract Review preset output name.

Screenshots
image

@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Jul 28, 2020
@jakubjezek001 jakubjezek001 added this to the 2.12 milestone Jul 28, 2020
@create-issue-branch
Copy link

@jakubjezek001 jakubjezek001 modified the milestones: 2.12, 2.13 Sep 15, 2020
@jakubjezek001
Copy link
Member Author

jakubjezek001 commented Sep 15, 2020

this issue is caused by code from extract_burnin.py:201

new_repre["name"] = new_name

@iLLiCiTiT do you thing this could be removed? I personally thing it is unlikely more burn-in variants will be used. what do you thing @mkolar or @antirotor ?

@iLLiCiTiT
Copy link
Member

I don't have opinion about that.

I think it was added because we wanted to have ability to create more than one burnin output from same source. With this it would require to rewrite the code and disable this ability...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants