Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

PYPE-663: separate venv for each deployed version #7

Closed
mkolar opened this issue Mar 17, 2020 · 1 comment · Fixed by #513
Closed

PYPE-663: separate venv for each deployed version #7

mkolar opened this issue Mar 17, 2020 · 1 comment · Fixed by #513
Labels
sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Milestone

Comments

@mkolar
Copy link
Member

mkolar commented Mar 17, 2020

We need virtual environments for every pype installation, separate dev and prod branches for example.

Suggestions:

we can create hash for installation path and use that for PYPE_ENV path… So:

on linux pype env root: /opt/pype/ and we have pype dev version on /pipeline/pype/dev/pype-setup

we create hash from path, lets say it is fc85bc so complete PYPE_ENV for it will be at /opt/pype/fc85bc

PYPE-663

@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Mar 17, 2020
@mkolar mkolar added this to the 3.0 milestone Mar 17, 2020
@mkolar mkolar added sponsored Client endorsed or requested affects: CORE labels Apr 16, 2020
@mkolar
Copy link
Member Author

mkolar commented Aug 21, 2020

this should be resolve by #211

@mkolar mkolar closed this as completed Aug 21, 2020
mkolar pushed a commit that referenced this issue Jun 22, 2022
Added shotgun-api3 source files to poetry lock
Sharkitty referenced this issue in Sharkitty/OpenPype Dec 20, 2022
* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)

* Changed regex search, clean up

* Readded mistakenly removed newline
kalisp pushed a commit that referenced this issue Mar 27, 2023
* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)

* Changed regex search, clean up

* Readded mistakenly removed newline
kalisp added a commit that referenced this issue May 2, 2023
…nted (#4722)

* Fix: Locally copied version of last published workfile is not incremented

* fix subset first match

* correct anatomy name

* Fix typo and linting

* keep source filepath for further path conformation

* fetch also input dependencies of workfile

* required changes

* lint

* fix case only one subset

* Enhancement:  copy last workfile as reusable methods (#6)

* Enhancement: copy last published workfile as reusable methods (WiP)

* Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile

* Plugged in the new methods + minor changes

* Added docstrings, last workfile optional argument, and removed unused code

* Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix

* Refactoring and fixed double dots

* Added match subset_id and get representation method, plus clan up

* Removed unused vars

* Fixed some rebasing errors

* delinted unchanged code and renamed get_representation into get_representation_with_task

* This time it's really delinted, I hope...

* Update openpype/modules/sync_server/sync_server.py

reprenation isn't the right spelling (:

Co-authored-by: Félix David <felixg.david@gmail.com>

* Changes based on reviews

* Fixed non imperative docstring and missing space

* Fixed another non imperative docstring

* Update openpype/modules/sync_server/sync_server.py

Fixed typo

Co-authored-by: Félix David <felixg.david@gmail.com>

Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Félix David <felixg.david@gmail.com>

* Fix: syntax error

* fix single subset case

* Restore sync server enabled test in hook

* Python2 syntax

* renaming and missing key case handling

* Fix local workfile overwritten on update in some cases (#7)

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)

* Changed regex search, clean up

* Readded mistakenly removed newline

* lint

* remove anticipated functions for cleaner PR

* remove funcs from entities.py

* change to get_last_workfile_with_version

* clean

* Update openpype/modules/sync_server/sync_server.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* removed get_last_published_workfile_path

* moved hook to sync server module

* fix lint

* Refactor - download only if not present

* Refactor - change to list instead of set

* Refactor - removing unnecessary code

last_published_workfile_path must exists or we wouldn't get there. Use version only from that.

* Refactor - removing unnecessary imports

* Added check for max fail tries

* Refactor - cleaned up how to get last workfile

* Updated docstrings

* Remove unused imports

Co-authored-by: Félix David <felixg.david@gmail.com>

* OP-5466 - run this on more DCC

* Updated documentation

* Fix - handle hero versions

Skip hero versions, look only for versioned published to get max version id.

* Hound

* Refactor - simplified download_last_published_workfile

Logic should be in pre hook

* Skip if no profile found

* Removed unwanted import

* Use collected project_doc

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Use cached project_settings

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Sharkitty <81646000+Sharkitty@users.noreply.github.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant