Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Collect audio for farm reviews. #1073

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

tokejepsen
Copy link
Member

Motivation

Audio is not added to our Nuke reviews.

Implementation

The collection will search for a subset called "audioMain" by default but this is a plugin attribute, so can be configured per studio.
On the subset a representation is hardcoded to "wav", which is more universally compliant, but we could make this a plugin attribute if a use-case is found.

If version, representation or file is not found, it'll only warn the user rather than fail.

@tokejepsen tokejepsen requested a review from mkolar March 2, 2021 09:47
@tokejepsen tokejepsen self-assigned this Mar 2, 2021
@mkolar mkolar added the 2x-dev label Mar 12, 2021
@mkolar
Copy link
Member

mkolar commented Mar 17, 2021

This seems quite dangerous and should probably be limited to solely nuke. As it is written now, it might overwrite scene collected audio from other hosts, which should take precedence.

I'd say, let's give it a host limit, so it can operate on any hosts, that don't hold audio directly inside. @tokejepsen what do you think?

@tokejepsen
Copy link
Member Author

Sure we could limit by host, but as it'll only ever warn users instead of failing where do you recon issues will arise?

@mkolar
Copy link
Member

mkolar commented Mar 22, 2021

where do you recon issues will arise

daily support tickets from all the artists who it doesn't apply to, but still warns them. We've had it on multiple occasions with pretty much each artist going to support when they get orange colour, half panicked what went wrong. The warning system in general doesn't work very well in this GUI to be honest.

@tokejepsen
Copy link
Member Author

Ready to merge now.

@mkolar mkolar added this to the 2.16.0 milestone Mar 22, 2021
@mkolar mkolar merged commit b6fea6e into ynput:2.x/main Mar 22, 2021
@mkolar
Copy link
Member

mkolar commented Mar 22, 2021

we§ll need to port this to 3.0

@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Mar 22, 2021
@tokejepsen tokejepsen deleted the 2.x/bugfix/nuke_farm_audio branch March 22, 2021 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants