Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Sites local settings by site name #1117

Merged
merged 13 commits into from
Mar 12, 2021

Conversation

iLLiCiTiT
Copy link
Member

Description

Site settings are now stored under "roots" key which is not correct, also all sites have same inputs for roots which is also not right. In reality is should work almost the same as before this PR but there are changes that give ability to be ready for future changes. Your previous local settings won't work because hierarchy of stored data has changed.

Changes

  • removed roots widget from local project overrides and replaced with sites widget (no difference in look)
  • instead of expecting only roots as input it is possible to define different inputs (only strings)
    • using of this feature is now hardcoded and predefined to be able set roots for active sites until providers will have ability to tell what can be modified
  • remote site combobox is hidden when there are no sites to set
  • implemented get_site_local_overrides which returns local settings overrides for given project name and site name

Note

@iLLiCiTiT iLLiCiTiT changed the title Sites local settings Sites local settings by site name Mar 11, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Mar 11, 2021
@iLLiCiTiT iLLiCiTiT requested review from kalisp and mkolar March 11, 2021 17:58
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Mar 12, 2021
@mkolar mkolar added this to the 3.0 milestone Mar 12, 2021
@mkolar mkolar merged commit 3c4d926 into sync_server_fix_local_drive Mar 12, 2021
@mkolar mkolar deleted the feature/sites_local_settings branch March 12, 2021 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants