This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Harmony: publishing performance issues #408
Merged
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though this makes it much faster, it also makes the resulting .tpl files empty :). So I'll call it a half-success. We'll need to figure out why that is happening before merging of course |
|
This should work better. It is almost the same as original one, but it is using |
mkolar
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When publishing workfiles from Harmony, publishing process could be stuck for minutes (or would time out after 2 is timeout limit wasn't changed). This was because
copyPase.pasteNewNode(...)creating tons of undo/redo points. This PR is merging whole extract template operation as one item for undo/redo system, dramatically reducing publishing speed to seconds.