This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Updating a look where the shader name changed, leaves the geo without a shader #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cleanup of references with failed reference edits
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| buttons = QtWidgets.QDialogButtonBox.Ok | ||
| else: | ||
| buttons = QtWidgets.QDialogButtonBox.Ok | \ | ||
| QtWidgets.QDialogButtonBox.Cancel |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
mkolar
changed the title
|
Looking good. However we need to solve the problem of dropping the reference edits on the shaders that haven't change at all. For example if I overide the hair colour in my scene and then update the look to the latest, I would expect the override to stay intact, the same way as it happens when you just replace the reference. So this solve the key problem of dropping shaders, but takes away some of the functionality. |
…shader_name_changed_leaves_the_geo_without_a_shader
mkolar
changed the title
kalisp
deleted the
bugfix/237-Updating_a_look_where_the_shader_name_changed_leaves_the_geo_without_a_shader
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reference clean-up and re-loading of reference on previous orphaned nodes.
Solves #237