This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Harmony: More efficient publishing #615
Merged
+118
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkolar
reviewed
Oct 9, 2020
There was a problem hiding this comment.
It is working fine. I've tested all the families. The code is much better with less calls to Harmony, But to be honest I didn't find any speed increase at all. Tried large scenes and smaller ones with old and new, and the differences are practically non-existent.
That being said, it's certainly better approach and I'm happy to merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
this feature is adding collector providing data further downstream for plugin so less queries to Harmony had to be made. Adding validation for scene name during rendering.