This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Camera name can be added to burnins. #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
commented
Oct 30, 2020
| @@ -110,6 +110,9 @@ def process(self, instance): | |||
| if not instance.data.get("keepImages"): | |||
| tags.append("delete") | |||
|
|
|||
| # Add camera node name to representation data | |||
| camera_node_name = pm.ls(camera)[0].nodeName() | |||
There was a problem hiding this comment.
Not sure if this is right way how to get the name.
Also not sure if this is right plugin to do this, was thinking that this may be done in Collect Review Data where camera is collected to instance data.
There was a problem hiding this comment.
you actually don't have to do this at all. camera name is already collected in the instance. you just need to grab it and use it.
There was a problem hiding this comment.
you just need to grab it and use it.
Do it, please :)
|
I fixed the collection to get camera transform instead of shape. All working good now. |
mkolar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes