Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint store context to workfile metadata (764) #766

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 1, 2020

Issue

It is possible to have opened multiple workfiles at the same time from different contexts. Which is not an issue for most of avalon workflow but is issue for publishing.

Changes

  • each workfile contain metadata with "project", "asset" and "task" to keep context in which were workfiles created.
  • these metadata are loaded in first TVPaint's collector and current context is modified by them
    • if workfile does not contain these metadata current context from api.Session is used
  • added validator for comparing project name (it is not allowed to publish in different project)

Possible issues

  • manually copy-pasted workfile (out of workfile tool) may contain metadata from different context
    • this can be fixed with resave
  • workfile change is not "Super Responsive" TVPaint won't change workfile context at the moment of tab change (it is required to click somwhere in gui).
🏴 this depends on
avalon-core ynput/avalon-core#233

Resolves #764

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 1, 2020
@mkolar mkolar added this to the 2.14.2 milestone Dec 1, 2020
@mkolar mkolar added the type: bug Something isn't working label Dec 1, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team December 1, 2020 17:18
@mkolar mkolar requested a review from 64qam December 1, 2020 22:20
@mkolar mkolar merged commit e1de7f1 into release/2.14.2 Dec 2, 2020
@mkolar mkolar deleted the bugfix/764-mixed-up-file-name-during-publishing branch December 4, 2020 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants