This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Harmony deadline submission #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| about.getMajorVersion(), | ||
| about.getMinorVersion() | ||
| ]; | ||
| } |
This was referenced Jan 13, 2021
added custom plugin - for error_code handling and preRenderInline
Fix - last character of file prefix is a number
| ) | ||
|
|
||
| pattern = '[0]{' + str(self._instance.data["leadingZeros"]) + \ | ||
| '}1\.[a-zA-Z]{3}' |
Number or non alpha (._) last characters in write node create problems. Remove them as this value is internal and not used in final publish either way
It seems that Harmony 17 needs at least one '.' in file_prefix. Cannot be last character though!
extract_template is extremely slow in 17, copy full scene for a workfile
| import pyblish.api | ||
|
|
||
| import pyblish.api | ||
| from avalon import harmony |
There was a problem hiding this comment.
'avalon.harmony' imported but unused
| import os | ||
| import pyblish.api | ||
|
|
||
| import pyblish.api |
There was a problem hiding this comment.
redefinition of unused 'pyblish' from line 2
Value in context.anatomyData is checked for [rR]ender presence
Subset on farm must match subset from manually rendered
kalisp
changed the title
mkolar
approved these changes
Jan 22, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Deadline rendering from Harmony.
Fixed harmony.py needs to be deployed to
DEADLINE_REPO_DIR/plugins/HarmonyScripts handles unwanted error code, which is probably DD issue and shouldn't happen and add possibility to create
preRenderInlineScriptargument which is needed in the case of multiple write nodes in the scene (default 'Top/Write' node is present always and shouldnt be rendered.)Requires:
ynput/pype-setup#83
ynput/pype-config#98