Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev docs] Show different retry methods available, and when to use each #17297

Open
miketheman opened this issue Dec 17, 2024 · 0 comments
Open
Labels
developer experience Anything that improves the experience for Warehouse devs documentation

Comments

@miketheman
Copy link
Member

There's a few different retry mechanisms in the codebase, and each has its own approach/gotchas that should be detailed for the readers.

A few approaches used in warehouse:

Other things to note, might be out of scope:

  • request.http sets max_retries to 1 and doesn't appear to be configurable (yet)
  • There's @google.api_core.retry decorators in currently-unused GCSFileStorage/GCSSimpleStorage classes, might be helpful to note that when using a service's SDKs, use their exceptions/retries? Uncertain.
  • Response.retry_after - sets a header to inform clients on when to retry
@miketheman miketheman added developer experience Anything that improves the experience for Warehouse devs documentation labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Anything that improves the experience for Warehouse devs documentation
Projects
None yet
Development

No branches or pull requests

1 participant