Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically build documentation for PRs #8166

Closed
brainwane opened this issue Jun 25, 2020 · 4 comments
Closed

automatically build documentation for PRs #8166

brainwane opened this issue Jun 25, 2020 · 4 comments
Labels
developer experience Anything that improves the experience for Warehouse devs documentation

Comments

@brainwane
Copy link
Contributor

@pradyunsg said:

Pull Requests on pip's tracker automatically get their documentation built + made available for preview. It's a check called "docs/readthedocs.org:pip" in the list of checks on the PR, and "details" link on it, points to the preview.

The section added in this PR is available at: https://pip--8493.org.readthedocs.build/en/8493/user_guide/#fixing-conflicting-dependencies

Any changes made on this PR will also get reflected on that page. :)

Originally posted by @pradyunsg in pypa/pip#8493 (comment)

I'd like that! It'd help me with, for instance, the work I'm doing with #8011. (My local environment is messed up.) Can we set that up for Warehouse PRs as well, since we also use Read the Docs to build and host our docs?

@brainwane brainwane added developer experience Anything that improves the experience for Warehouse devs documentation labels Jun 25, 2020
@pradyunsg
Copy link
Contributor

pip was a beta tester for this functionality in RTD, which has now become a checkbox to tick in the read the docs admin UI.

https://docs.readthedocs.io/en/stable/guides/autobuild-docs-for-pull-requests.html

@di
Copy link
Member

di commented Jun 26, 2020

I've checked the box, let's see what happens!

@brainwane
Copy link
Contributor Author

@di If you compare #8011 and pypa/pip#8493 you see that the list of checks at the bottom of pypa/pip#8493 includes

docs/readthedocs.org:pip — Read the Docs build succeeded! [link to docs]

I don't see that in the Warehouse PR (though I just force-pushed there). So I'm not sure the automated build is happening, or where I would look for the link.

@di
Copy link
Member

di commented Jun 26, 2020

OK, I've now checked the box, and hit "Save", and #8011 now has a "docs/readthedocs.org:warehouse — Read the Docs build succeeded!" status.

@di di closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Anything that improves the experience for Warehouse devs documentation
Projects
None yet
Development

No branches or pull requests

3 participants