Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Deprecation]: ParameterGroup, BuiltinParameterGroup, GetLabelFor, GetParameterGroupTypeId, GetBuiltInParameterGroup #2381

Closed
4 tasks done
jmcouffin opened this issue Aug 27, 2024 · 2 comments
Closed
4 tasks done

[API Deprecation]: ParameterGroup, BuiltinParameterGroup, GetLabelFor, GetParameterGroupTypeId, GetBuiltInParameterGroup #2381

jmcouffin opened this issue Aug 27, 2024 · 2 comments
Assignees
@jmcouffin
Labels
API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}]
Milestone
pyRevit 5 RC

Comments

@jmcouffin
Copy link
Contributor

jmcouffin commented Aug 27, 2024 •
edited
Loading

🐞 Describe the bug

Need to review and change API deprecated methods:

Handle with:

if HOST_APP.is_newer_than(2023):
    # new method
else:
    # old method

Additional context

see https://discourse.pyrevitlabs.io/t/release-date-pyrevit-2025/3083/60?u=jean-marc
and #2380 for similar handling
@jmcouffin jmcouffin added the API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}] label Aug 27, 2024
@jmcouffin jmcouffin added this to the pyRevit 5 RC milestone Aug 27, 2024
@jmcouffin
Copy link
Contributor Author

@acco-jpitts

@jmcouffin jmcouffin self-assigned this Aug 27, 2024
@jmcouffin jmcouffin mentioned this issue Sep 9, 2024
Merged
@jmcouffin
Copy link
Contributor Author

fixed by 2392
I went around and looked for each method in the codebase.
Only 2 files required fixing. The rest was handled previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcouffin jmcouffin

Labels
API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}]
Projects
pyRevit
Status: Done
Milestone
pyRevit 5 RC
Development

No branches or pull requests
1 participant
@jmcouffin